D8958: Fix unintentional breadcrumb menu item activation

Алексей Шилин noreply at phabricator.kde.org
Mon Feb 19 03:04:49 UTC 2018


aleksejshilin added a comment.


  In D8958#209050 <https://phabricator.kde.org/D8958#209050>, @dfaure wrote:
  
  > Instead of the bool member, isn't it enough to test the distance again in mouseReleaseEvent? AFAIK that's how most widget do it. It also leads to one difference of behaviour in case someone moves the mouse a bit and then back to the original position, in that case the mouseReleaseEvent considers that no move happened (not sure if that's what you want here).
  
  
  If user moved the mouse considerably, then it's assumed to be intentional, and the subsequent release event shouldn't be ignored even if the final position is the same as the initial one. This way it is consistent with drag'n'drop behavior.
  
  Besides, only the first mouse release event should be ignored, so a flag is needed anyway.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8958

To: aleksejshilin, #frameworks, dfaure
Cc: broulik, ngraham, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180219/af180091/attachment.html>


More information about the Kde-frameworks-devel mailing list