D10617: Fix "ambiguous shortcut" issue introduced with D10314

[Mark Gaiser]

markg added a comment.


  In D10617#208703 <https://phabricator.kde.org/D10617#208703>, @elvisangelaccio wrote:
  
  > In D10617#208513 <https://phabricator.kde.org/D10617#208513>, @ngraham wrote:
  >
  > > The shortcut won't affect other apps since the file dialog its its own context. Even if the host app uses F12 for something, the file dialog will grab the key first, so there's no "ambiguous shortcut" issue.
  >
  >
  > Yes, you won't get the ambiguous shortcut dialog but it'd be a bad idea to use F12 for two different things within the same app (the file dialog //is// part of the app).
  
  
  If it were F11 (which it was) then this patch would be very intrusive as you could have potentially broken fullscreen support (with F11), but it isn't it's F12..
  Note that you can in fact see this "broken fullscreen". Open gwenview, open an image and press F11, then do CTRL+O to open the file open dialog. Now F11 only has effect on that file open dialog.
  
  But for F12, i don't see anything wrong. As far as i'm aware it isn't bound to any really crucial actions (i would call fullscreen crucial aka F11).
  F12 in chrome opens the developer console.
  F12 in konsole prints the tilde sign (there is another dedicated key for that, right under escape)
  
  F12 seems fine to me. Yes, you'd get into the weird issue that F12 in the app might have a different behavior in a file open dialog opened by the very same app, but that is with every key you choose.
  As long as we are consistent in keys which i thing Nate is very much trying to do (good job!).
  
  Also, note that F11 in kwrite binds to something completely different (show line numbers).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10617

To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio
Cc: michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180218/a33f3ed9/attachment.html>