D10603: Make DMTX dependency optional

[Sune Vuorela]

svuorela added a comment.


  Thanks. The ability to cleanly do something like that was one of the reasons for the api changes I did between qt4 and qt5.

INLINE COMMENTS

> prison.cpp:44
> +#ifdef HAVE_DMTX
>          case Prison::DataMatrix:
>              return new DataMatrixBarcode;

I'm wondering if it isn't better to have

  case Prison::DataMatrix:
  #ifdef HAVE_DTMX
  return new DataMatrixBarcode;
  #else
  return nullptr
  #endif

to avoid potentially having a unhandled enum value in switch warning.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D10603

To: vkrause, #frameworks, svuorela
Cc: michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180218/08baa89a/attachment.html>