D10543: fix crashing with duplicate entries

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Feb 15 16:19:00 UTC 2018


apol added inline comments.

INLINE COMMENTS

> karchive.cpp:829
>  {
> -    if (d->entries.value(entry->name())) {
> -        /*qCWarning(KArchiveLog) << "directory " << name()
> -                    << "has entry" << entry->name() << "already";*/
> -        delete entry;
> +    if (d->entries.value(entry->name()) == entry) {
> +        qCWarning(KArchiveLog) << "directory " << name()

Cache the value not to query twice?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D10543

To: sandsmark, dfaure, #frameworks
Cc: apol, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180215/5d6ac2c6/attachment.html>


More information about the Kde-frameworks-devel mailing list