D10543: fix crashing with duplicate entries

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Feb 15 14:20:18 UTC 2018


apol added inline comments.

INLINE COMMENTS

> karchive.cpp:832-833
> +                    << "has entry" << entry->name() << "already";
> +        delete d->entries.take(entry->name());
>          return;
>      }

Haven't looked at the code yet, but this doesn't make much sense.
Since it's already in the map, we remove it from the map?

Maybe this should remove the `return` then.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D10543

To: sandsmark, dfaure, #frameworks
Cc: apol, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180215/fb7a6cda/attachment.html>


More information about the Kde-frameworks-devel mailing list