D9814: [KIconLoader] Take into account devicePixelRatio for overlays

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> kiconloader.cpp:542
>  
> +        startPoint /= pix.devicePixelRatio();
> +

Typically it's a lot easier to do everything in logical co-ordinates, rather than effectively convert co-ordinates to device pixels and then convert back. Especially if you ever mix up paint devices with different ratios.

But in this case it works...so ship it.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D9814

To: broulik, #frameworks, davidedmundson, apol
Cc: apol, emmanuelp, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180215/b91fec6d/attachment.html>