D7968: Forward QComboBox signals instead of QComboBox lineedit signals

Jeremy Whiting noreply at phabricator.kde.org
Wed Feb 14 23:47:58 UTC 2018


whiting added a comment.


  Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing the textChanged signal on the KUrlRequester anymore when programatically setting the url with the KUrlComboBox we give to the KUrlRequester via it's setUrl method. Looking at KUrlComboBox::setUrl it's blocking signals in the body of setUrl and since we are not connecting to the QLineEdit anymore we never get that signal.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7968

To: mwolff, apol, dfaure
Cc: whiting, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180214/68ee197d/attachment.html>


More information about the Kde-frameworks-devel mailing list