D10414: Add move semantics support to KIO::UDSEntry.

David Faure noreply at phabricator.kde.org
Tue Feb 13 08:44:27 UTC 2018


dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Sorry, just spotted one last typo (and two missing @since), feel free to push after fixing.

INLINE COMMENTS

> udsentrytest.cpp:231
> +{
> +    // Create a temporaty file. Just to make a UDSEntry further down.
> +    QTemporaryFile file;

Typo: tempora*r*y

> udsentry.h:94
> +    /**
> +     * Move constructor
> +     */

@since 5.44

> udsentry.h:104
> +    /**
> +     * Move assignment
> +     */

@since 5.44

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: apol, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180213/2b882ed2/attachment.html>


More information about the Kde-frameworks-devel mailing list