D10333: Introduce K_PLUGIN_CLASS_WITH_JSON

Albert Astals Cid noreply at phabricator.kde.org
Wed Feb 7 22:32:14 UTC 2018


aacid added a comment.


  In https://phabricator.kde.org/D10333#202036, @kossebau wrote:
  
  > Makes sense to me to have a shorter version for the common case of just one registered plugin. Less boilerplate :)
  >
  > Please add a note in the API dox that this macro is for the case of just one plugin class, and link to K_PLUGIN_FACTORY_WITH_JSON for the case someone wants multiple plugins (yes, there are some use-cases for that).
  
  
  Hmm, i already have a \see K_PLUGIN_FACTORY_WITH_JSON my guess is that people that find out that this doesn't do what they want, they'll go there?
  
  > Please also add K_PLUGIN_CLASS_WITH_JSON (or whatever name it will be in the end) to the list KCoreAddons_AUTOMOC_MACRO_NAMES in the toplevel CMakeLists.txt.
  
  Done, thanks.
  
  And yes, I'm open for better naming, not totally happy with it to be honest.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10333

To: aacid
Cc: kossebau, apol, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180207/29e37004/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list