D10312: FileUndoManager: don't delete non-existing local files

David Faure noreply at phabricator.kde.org
Mon Feb 5 14:52:07 UTC 2018


dfaure added inline comments.

INLINE COMMENTS

> fileundomanager.cpp:404
> +    } else if (commandType == FileUndoManager::Copy) {
> +        d->slotLock();
> +        return;

Where's the corresponding call to slotUnlock?

I think you only wanted to update the state of the action, maybe better to do that directly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10312

To: elvisangelaccio, dfaure
Cc: ngraham, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180205/9ee43ed8/attachment.html>


More information about the Kde-frameworks-devel mailing list