D10250: track the validity of the texture

David Edmundson noreply at phabricator.kde.org
Mon Feb 5 11:41:10 UTC 2018


davidedmundson added a comment.


  > so in that case would be a problem that potentially could come up elsewhere as would make the logic of managedtexturenode not completely correct in those edge cases
  
  Textures will never be deleted by anyone else.
  
  Docs say:
  
  > Warning: The returned texture is not memory managed by the scene graph and must be explicitly deleted by the caller on the rendering thread. This is achieved by deleting the texture from a QSGNode destructor or by using deleteLater() in the case where the texture already has affinity to the rendering thread.
  
  However, because it's in a managed texture node, it will get deleted when the node dies.
  The node definitely will be killed when you switch window.
  
  *if* that's the case you're hitting, you're guarding the wrong thing, and will need to guard the node not the texture.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D10250

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180205/2db8082e/attachment.html>


More information about the Kde-frameworks-devel mailing list