D10314: Use F11 as the shortcut to toggle the aside preview

Nathaniel Graham noreply at phabricator.kde.org
Mon Feb 5 02:01:43 UTC 2018


ngraham created this revision.
ngraham added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  FEATURE: 389880
  FIXED-IN: 5.44

TEST PLAN
  Shortcut works and toggles the aside preview.
  
  However, in doing so, another pre-existing bug is triggered: the file dialog doesn't eat the keyboard input, so if the app that spawned it has something bound to F11, you'll erroneously get the "Ambiguous shortcut" message (even though the keystroke is/should be passed only to the file dialog, not the host app). Help solving this would be appreciated.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10314

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham, #frameworks
Cc: michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180205/2db1cc57/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list