D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

Martin Flöser noreply at phabricator.kde.org
Sun Feb 4 16:00:28 UTC 2018


graesslin created this revision.
graesslin added reviewers: Frameworks, KWin, Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REVISION SUMMARY
  Qt seems to damage and commit child subsurfaces although their parent
  got destroyed. This actually doesn't make any sense as without a parent
  surface they cannot be shown. But nevertheless we should not crash in
  such a situation.
  
  This change guards the places in the commit handling code where the
  parent gets accessed.
  
  BUG: 389231

TEST PLAN
  New test case which exposes the problem

REPOSITORY
  R127 KWayland

BRANCH
  subsurface-parent-destroyed

REVISION DETAIL
  https://phabricator.kde.org/D10300

AFFECTED FILES
  autotests/client/test_wayland_subsurface.cpp
  src/server/subcompositor_interface.cpp
  src/server/surface_interface.cpp

To: graesslin, #frameworks, #kwin, #plasma
Cc: plasma-devel, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180204/b5ce911a/attachment.html>


More information about the Kde-frameworks-devel mailing list