D10282: Use the destination KFileItem object to figure out of it's writable instead of creating a KFileItemListProperties which basically does the same thing but more expensive.
Mark Gaiser
noreply at phabricator.kde.org
Sat Feb 3 22:51:37 UTC 2018
markg created this revision.
markg added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
markg requested review of this revision.
REVISION SUMMARY
Use KFileItem::isWritable instead of the detour with KFileItemListProperties.
It's basically the same, only more expensive.
KFileItem::isWritable is already quite expensive on it's own.
This saves cycles but to be fair, the amount is neglectable.
TEST PLAN
I verified that the paste action in Dolphin (under the Right mouse button) still works.
Is active (when writable) and shows the correct text as before.
REPOSITORY
R241 KIO
BRANCH
kfileitemproperties_optimization
REVISION DETAIL
https://phabricator.kde.org/D10282
AFFECTED FILES
src/widgets/paste.cpp
To: markg, dfaure
Cc: #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180203/8d160704/attachment.html>
More information about the Kde-frameworks-devel
mailing list