D10273: Create proper SocketAddress
Thiago Macieira
noreply at phabricator.kde.org
Sat Feb 3 17:40:09 UTC 2018
thiago added a comment.
Looks good.
INLINE COMMENTS
> fdsender.cpp:24
>
> FdSender::FdSender(const std::string &path)
> : m_socketDes(-1)
The problem here is the API. Why is it using std::string in the first place?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10273
To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180203/a8934375/attachment.html>
More information about the Kde-frameworks-devel
mailing list