D10273: Create proper SocketAddress

[Oswald Buddenhagen]

ossi added inline comments.

INLINE COMMENTS

> sharefd_p.h:60
> -        ::strcpy(a.sun_path, finalPath.c_str());
> -        ::unlink(finalPath.c_str());
> -#endif

you still need to address that *somehow* ;)

> sharefd_p.h:61
> +        if (pathSize > 0 && pathSize < sizeof(a.sun_path) - 1) {
> +            memcpy(a.sun_path, path.constData(), sizeof(a.sun_path) - 1);
> +        }

the correct length is pathSize + 1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180203/7d17bfeb/attachment.html>