D10266: Improve error handling in file ioslave
David Faure
noreply at phabricator.kde.org
Sat Feb 3 10:27:42 UTC 2018
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Ah OK so it was dead code. Removing dead code is always good.
The patch looks ok to me now -- assuming the unittests still pass, which you didn't mention in the testing section of this review request.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10266
To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180203/ccbc8f55/attachment.html>
More information about the Kde-frameworks-devel
mailing list