D10266: Improve error handling in file ioslave

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> file_unix.cpp:122
>      if (execAction.status() == KAuth::Action::AuthorizedStatus) {
> -        return execWithElevatedPrivilege(action, arg1, arg2, arg3);
> +        return execWithElevatedPrivilege(action, args, errno);
>      }

Why errno here? What sets it? Shouldn't that be errcode?

> file_unix.cpp:815
> +        out << arg;
>      }
>  

What happened to the code that was passing socketPath() for OPEN and OPENDIR? It wasn't needed?

> file_win.cpp:392
>  {
> -    return PrivilegeOperationReturnValue::failure();
> +    return PrivilegeOperationReturnValue::failure(KIO::ERR_ACCESS_DENIED);
>  }

Why not just return the errcode that was given as input?
Won't this change mess up all error handling on Windows, otherwise, by "eating" the proper error codes?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10266

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180203/954a8384/attachment-0001.html>