D10045: remote: don't create entries with empty names

David Faure noreply at phabricator.kde.org
Sat Feb 3 09:07:09 UTC 2018


dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Minor: now readName() is called 3 times, I think this should go into a local variable.
  
  I don't understand why the name can be empty in one of the desktop files, that seems quite strange. But oh well.

INLINE COMMENTS

> mwolff wrote in remoteimpl.cpp:56
> is this OK? or are there other entries that should be shown under remote:/ ?

I'm not 100% sure, but given the code in statNetworkFolder and below, I think every interesting file always ends with .desktop.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10045

To: mwolff, dfaure
Cc: dhaumann, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180203/45935960/attachment.html>


More information about the Kde-frameworks-devel mailing list