D10261: Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.

Mark Gaiser noreply at phabricator.kde.org
Sat Feb 3 01:30:19 UTC 2018


markg created this revision.
markg added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
markg requested review of this revision.

REVISION SUMMARY
  As the title says. Minor optimization.

TEST PLAN
  Ran the testcases, all pass just fine.
  Also in callgrind it's one less call to the KFileItemListProperties constructor that takes a KFileItemList. A small win :)

REPOSITORY
  R241 KIO

BRANCH
  KFileItemListProperties_stage2

REVISION DETAIL
  https://phabricator.kde.org/D10261

AFFECTED FILES
  src/widgets/dropjob.cpp

To: markg, dfaure
Cc: #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180203/ff74049e/attachment.html>


More information about the Kde-frameworks-devel mailing list