D9672: Don't emit error signal before we tried all list commands.
David Faure
noreply at phabricator.kde.org
Sat Feb 3 00:27:20 UTC 2018
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
ERR_* is KIO-wide, and isn't technically an enum.
But the proper error code for no error is KJob::NoError (which is 0). Can you switch to that, and adjust the second comment, and kill the first comment altogether? (redundant with code and with 2nd comment)
Thanks! (and sorry for the delay, too)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9672
To: wcpan, dfaure
Cc: cfeck, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180203/f623399e/attachment.html>
More information about the Kde-frameworks-devel
mailing list