D9966: [KIO] Fix issues with sharing of file descriptor

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thiago, Ossi, looks ok to you too?
  
  (Tagging tomorrow...)

INLINE COMMENTS

> dfaure wrote in sharefd_p.h:51
> Is strlen needed? It seems to me that sun_path will be null if make_address failed, so a simple null-pointer check would be enough here. Plus I remember some implementations of strlen breaking on null pointers...

Looks good.

My own comment was partly nonsense, I see now (sun_path can't be a null pointer). But still this change is for the better, it makes it faster.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180202/84d37ce4/attachment.html>