D10124: Faster simplejob start

[Jaime Torres Amate]

jtamate added a comment.


  Unfortunately, the last connect creates a memory leak:
  
  1018== 10,152 (72 direct, 10,080 indirect) bytes in 1 blocks are definitely lost in loss record 928 of 943
  ----------------------------------------------------------------------------------------------------------
  
  1018==    at 0x4C2E6FF: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
  --------------------------------------------------------------------------------------------------------------
  
  1018==    by 0xCAEFCFC: QObjectPrivate::connectImpl(QObject const*, int, QObject const*, void**, QtPrivate::QSlotObjectBase*, Qt::ConnectionType, int const*, QMetaObject const*) (in /usr/lib64/libQt5Core.so.5.10.0)
  ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  
  1018==    by 0xCAF0084: QObject::connectImpl(QObject const*, void**, QObject const*, void**, QtPrivate::QSlotObjectBase*, Qt::ConnectionType, int const*, QMetaObject const*) (in /usr/lib64/libQt5Core.so.5.10.0)
  ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  
  1018==    by 0x9141BB5: std::enable_if<QtPrivate::FunctionPointer<KIO::SimpleJobPrivate::start(KIO::Slave*)::{lambda(unsigned long long)#4}>::ArgumentCount==(-1), QMetaObject::Connection>::type QObject::connect<void (KIO::SlaveInterface::*)(unsigned long long), KIO::SimpleJobPrivate::start(KIO::Slave*)::{lambda(unsigned long long)#4}>(QtPrivate<void (KIO::SlaveInterface::*)(unsigned long long)>::Object const*, std::enable_if<QtPrivate::FunctionPointer<KIO::SimpleJobPrivate::start(KIO::Slave*)::{lambda(unsigned long long)#4}>::ArgumentCount==(-1), QMetaObject::Connection>::type, QObject const*, QtPrivate::FunctionPointer, Qt::ConnectionType) (qobject.h:338)
  ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  
  1018==    by 0x913FCCB: KIO::SimpleJobPrivate::start(KIO::Slave*) (simplejob.cpp:151)
  -------------------------------------------------------------------------------------
  
  1018==    by 0x914B3D1: KIO::TransferJobPrivate::start(KIO::Slave*) (transferjob.cpp:362)
  -----------------------------------------------------------------------------------------
  
  1018==    by 0x914D063: startJob(KIO::SimpleJob*, KIO::Slave*) (scheduler.cpp:60)
  ---------------------------------------------------------------------------------
  
  1018==    by 0x914F661: KIO::ProtoQueue::startAJob() (scheduler.cpp:635)
  ------------------------------------------------------------------------
  
  1018==    by 0x9152AC4: KIO::ProtoQueue::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_scheduler_p.cpp:252)
  -------------------------------------------------------------------------------------------------------------------------------
  
  1018==    by 0xCAEBDB9: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib64/libQt5Core.so.5.10.0)
  --------------------------------------------------------------------------------------------------------------
  
  1018==    by 0xCAF8236: QTimer::timeout(QTimer::QPrivateSignal) (in /usr/lib64/libQt5Core.so.5.10.0)
  ----------------------------------------------------------------------------------------------------
  
  1018==    by 0xCAF8567: QTimer::timerEvent(QTimerEvent*) (in /usr/lib64/libQt5Core.so.5.10.0)
  ---------------------------------------------------------------------------------------------

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks, mwolff
Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180202/704a0ea7/attachment-0001.html>