D17167: Provide a method of assigning custom default icons for non-XDG dirs

[Nathaniel Graham]

ngraham added a comment.


  In D17167#371906 <https://phabricator.kde.org/D17167#371906>, @cfeck wrote:
  
  > But why hardcode the list in the source, instead of reading it from a file/resource that the user could expand?
  
  
  I don't see the benefit of putting the data into a configuration file. The whole idea is to make KIO default to picking a nicer icon when the user creates a folder with a name that would benefit from having a a nice-looking Breeze icon rather than just the standard folder icon. Currently the only one in the list is "Games", but this could be extended over time for other useful folder names. E.g. "Books" "Source Code", etc.
  
  > Ideally, the "New Folder" dialog would have a button to pick an icon
  
  That sounds like a good idea. But even with that, this patch would still be useful because it could pre-populate that icon picker with a folder icon more appropriate than just the default one. For example when you type the name "Games" into the text field, the default icon in the picker would automatically change to `folder-games`.
  
  This doesn't add any new features that users can't already accomplish themselves using handmade .desktop files or the existing icon picker functionality. It just tries to make KIO a little smarter and more considerate about choosing the default icon when the user creates commonly-named folders. A user specifically requested this functionality in https://bugs.kde.org/show_bug.cgi?id=401218

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17167

To: ngraham, #frameworks, cfeck, broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181228/5afda2f5/attachment-0001.html>