D17623: Add YaST and new preference icons

Noah Davis noreply at phabricator.kde.org
Fri Dec 28 17:40:22 GMT 2018


ndavis added a comment.


  In D17623#382989 <https://phabricator.kde.org/D17623#382989>, @ngraham wrote:
  
  > In D17623#382912 <https://phabricator.kde.org/D17623#382912>, @ndavis wrote:
  >
  > > We still haven't figured out where to put all of the `yast-*` icons. Most of them are now symlinks to preferences icons, but that doesn't fix the fact that this patch can't pass the scalable test. This is because `apps/32` is a fixed size directory. I don't think `preferences/` should be used for the YaST icons because `preferences/` is meant to be used for our settings category icons and YaST is 3rd party. Would it be acceptable to change `apps/32` to the following?
  > >
  > >   [apps/32]
  > >   Size=32
  > >   Context=Applications
  > >   Type=Scalable
  > >   MinSize=24
  > >   MaxSize=32
  > >
  > >
  > > This way the icons can be used in YaST and Plasma won't try to use a 32px icon when a 48 px icon should be used for applications like Dolphin
  >
  >
  > I don't see why not. What would be the drawbacks of this approach that you can foresee?
  
  
  I don't see any, but it seems like a change that doesn't really do anything besides make it easier to satisfy the scalable test.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181228/fae17811/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list