D17190: Add level api from Kirigami.Heading

Christoph Feck noreply at phabricator.kde.org
Fri Dec 28 03:00:15 GMT 2018


cfeck added inline comments.

INLINE COMMENTS

> ktitlewidget.cpp:132
>      titleFrame->setBackgroundRole(QPalette::Base);
> +    titleFrame->setContentsMargins(0, 0, 0, 0);
>  

Setting 0 margins effectively disables the frame; the Breeze setting to keep frames around page titles is no longer respected.

If this is intended, the frame shouldn't set a background role (and the code would have to be checked regarding correct foreground colors).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg, ngraham
Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181228/6eb9e2c5/attachment.html>


More information about the Kde-frameworks-devel mailing list