D17743: Extend getExtensionFromPatternList reg exp filtering

David Edmundson noreply at phabricator.kde.org
Sat Dec 22 22:29:08 GMT 2018


davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  getExtensionFromPatternList turns a filter string such "*.cpp" etc into
  an extension ".cpp".
  
  It tries to filter out any filter string that could be a glob pattern.
  However it didn't handle "[]" characters.
  
  See https://phabricator.kde.org/D17677 and D17738 <https://phabricator.kde.org/D17738>

TEST PLAN
  Modified kfilewidgettest_gui test and confirmed
  that "automatically select file extension" checkbox didn't 
  insert irrelevant chars in the filename.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17743

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181222/6de088f5/attachment.html>


More information about the Kde-frameworks-devel mailing list