D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

[Alexey Min]

alexeymin accepted this revision.
alexeymin added a comment.
This revision is now accepted and ready to land.


  I tested this, it indeed fixes 390225
  Withoug this patch, generated pkgconfig file was:
  
    prefix=/usr
    exec_prefix=bin
    libdir=lib/x86_64-linux-gnu
    includedir=include
    
    Name: libKActivities
    Description: libKActivities is a C++ library for using KDE activities
    URL: http://www.kde.org
    Requires: Qt5Core
    Version: 
    Libs: -Llib/x86_64-linux-gnu -lKF5Activities
    Cflags: -Iinclude
  
  With this, version field is filled in and full paths are specified:
  
    Name: libKActivities
    Description: libKActivities is a C++ library for using KDE activities
    Version: 5.54.0
    Libs: -L/usr/lib/x86_64-linux-gnu -llibKActivities
    Cflags: -I/usr/include/libKActivities 
    Requires: Qt5Core
  
  So, +1

REPOSITORY
  R6 KActivities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17718

To: cgiboudeaux, cfeck, #build_system, alexeymin
Cc: alexeymin, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181221/bdf4f008/attachment.html>