D17681: RFC: Cache translated strings in Job::emit functions

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Dec 19 09:32:40 GMT 2018


broulik created this revision.
broulik added reviewers: davidedmundson, dfaure, chinmoyr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  These are called repeatedly for every single file processed and we end up spending non-trivial amounts of time doing translation work.

TEST PLAN
  Not sure about implications on thread-safety and we don't evcit those strings anymore, but they're not that many..

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17681

AFFECTED FILES
  src/core/job.cpp

To: broulik, davidedmundson, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181219/f0753469/attachment.html>


More information about the Kde-frameworks-devel mailing list