D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> chinmoyr wrote in copyjob.cpp:419
> For file permissions, 'file:' and 'trash:' use the result of QT_LSTAT, 'archive:' makes use of stat, 'sftp:' uses sftp_lstat, and smb sets UDS_ACCESS to 0500. These are the kioslaves(I found) which KDE ships and set UDS_ACCESS entry. I think using UDSEntry can be considered here.

> These are the kioslaves(I found) which KDE ships and set UDS_ACCESS entry. I think using UDSEntry can be considered here.

Well I was completely wrong here. There are plenty other protocols that set UDS_ACCESS and someone needs to check if their UDSEntry has the correct permission since flags are being set manually. For the time being this TODO should be here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17632

To: dfaure, shubham, broulik, bruns
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181217/b1ec341c/attachment-0001.html>