D17619: Unit test and fix for bug 401552

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcoredirlister.cpp:1580
> +            while (!dir->lstItems.isEmpty()) {
> +                const KFileItem oldItem = dir->lstItems.takeFirst();
> +                KFileItem newItem = oldItem;

Why is this modifying lstItems? That's a somewhat costly operation, if it's not needed. Why not a normal readonly iteration?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17619

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181216/26f8c38d/attachment-0001.html>