D17596: [KDirOperator] Allow renaming files from the context menu

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dhaumann wrote in kdiroperator.cpp:907-909
> Does dialog->open() block? If so, do we have to new the dialog at all? (Only reason I can think of is some DBus crash, see https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0 but that would require a better fix).

Nope, `dialog->open()` does not block.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17596

To: ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181215/55ddb656/attachment-0001.html>