D17596: [KDirOperator] Allow renaming files from the context menu

Elvis Angelaccio noreply at phabricator.kde.org
Sat Dec 15 16:17:03 GMT 2018


elvisangelaccio added inline comments.

INLINE COMMENTS

> kdiroperator.cpp:907-909
> +    dialog->show();
> +    dialog->raise();
> +    dialog->activateWindow();

I think we should just use `dialog->open()` here. I see you've copied these 3 lines from Dolphin, but we should also fix it there (the rename dialog should really be modal).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17596

To: ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181215/4be59fb0/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list