D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Elvis Angelaccio]

elvisangelaccio reopened this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kcoredirlister.cpp:1576-1577
> +            for (auto kit = dir->lstItems.begin(), kend = dir->lstItems.end(); kit != kend; ++kit) {
>                  const KFileItem oldItem = *kit;
> +                KFileItem newItem = oldItem;
>  

Stacktrace from bug #401552 <https://bugs.kde.org/show_bug.cgi?id=401552> points here. Reverting this commit seems to fix the crash.

@jtamate Can you have a look?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: elvisangelaccio, bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181214/0b748ddd/attachment.html>