D17355: Align Plasma QML button content in center if it has an icon

[Björn Feber]

GB_2 planned changes to this revision.
GB_2 added a comment.


  In D17355#376973 <https://phabricator.kde.org/D17355#376973>, @mart wrote:
  
  > in general, buttons with icons may be stacked vertically, which for me makes a general -1
  
  
  But it's not consistent with Qt Widgets and looks kind of weird.
  
  In D17355#376975 <https://phabricator.kde.org/D17355#376975>, @mart wrote:
  
  > In D17355#371722 <https://phabricator.kde.org/D17355#371722>, @GB_2 wrote:
  >
  > > Improved code.
  > >  How `qmlscene tests/components/button.qml` looks like:
  > >  F6457867: Plasma QML Button Content Align qmlscene (1).png <https://phabricator.kde.org/F6457867>
  > >  For some reason "elide" doesn't work...
  >
  >
  > is elide working on the latest revision?
  
  
  No, I still didn't figure that out.
  
  In D17355#376976 <https://phabricator.kde.org/D17355#376976>, @mart wrote:
  
  > pleaase add the changes to plasmacomponents3 as well
  
  
  I will do that when this is done.
  
  This needs revision, but it's not really my priority.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17355

To: GB_2, #plasma, #vdg
Cc: mart, davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel, michaelh, crozbo, ndavis, ZrenBot, firef, bruns, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181214/cfc83e5d/attachment.html>