D17528: Refactor SlaveInterface::calcSpeed

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> slaveinterface_p.h:59
> +    QVector<KIO::filesize_t> sizes;
> +    QVector<qint64> times;
> +    QElapsedTimer elapsed_timer;

You could use a struct for both, e.g.:

  struct SpeedSample {
      KIO::filesize_t remainder;
      qint64 elapsedTime;
  }
  QVector<SpeedSample> transferSpeed;

This would emphasize the two values always come in pairs, and would even remove some code above.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181213/826229ed/attachment-0001.html>