D17545: Do not stat move/copy job if the destination file system does not support writing

[Kai Uwe Broulik]

broulik added a comment.


  The bug report is about checking whether it's writable, you're checking the protocol here, and `file` will always "support writing". This patch could still make sense, though.

INLINE COMMENTS

> copyjob.cpp:864
> +            QPointer<CopyJob> that = q;
> +            emit q->warning(q, buildErrorString(ERR_CYCLIC_COPY, m_currentDestURL.toDisplayString()));
> +            if (that) {

Not sure `ERR_CYCLIC_COPY` is the correct error for this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181212/a04d581e/attachment.html>