D17518: Adapt favicon test to www.kde.org changes

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed Dec 12 14:38:06 GMT 2018


bruns added a comment.


  In D17518#375713 <https://phabricator.kde.org/D17518#375713>, @broulik wrote:
  
  > I also thought the favicon was too large for `FavIconJob` to download
  
  
  The now existing www.kde.org/favicon.ico ideed was to large for the favicon job, so the unchanged code got an "too large" error instead of the expected "does not exist". After pointing the job to a nonexisting file, this no longer is an issue.

REPOSITORY
  R241 KIO

BRANCH
  favicon_test

REVISION DETAIL
  https://phabricator.kde.org/D17518

To: bruns, #frameworks, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181212/1980b6f2/attachment.html>


More information about the Kde-frameworks-devel mailing list