D17529: [proxysetting] Fix build with NM 1.4
Jan Grulich
noreply at phabricator.kde.org
Wed Dec 12 13:24:28 GMT 2018
jgrulich added a comment.
In D17529#375913 <https://phabricator.kde.org/D17529#375913>, @wbauer wrote:
> In D17529#375909 <https://phabricator.kde.org/D17529#375909>, @jgrulich wrote:
>
> > So maybe go with the easiest approach and just instead of defines use 0 and 1?
>
>
> Fine with me.
>
> Should I make that conditional depending on the NM version maybe, or just unconditionally use the numbers?
Unconditionally. It doesn't matter if it uses defines or numbers directly.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D17529
To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181212/d6bfbb96/attachment.html>
More information about the Kde-frameworks-devel
mailing list