D17459: SearchBar: Add Cancel button to stop long running tasks

loh tar noreply at phabricator.kde.org
Wed Dec 12 01:34:05 GMT 2018


loh.tar updated this revision to Diff 47408.
loh.tar added a comment.


  - Use new (dis)connect style in touched functions
  - Clean-Up no longer needed MovingRange
  
  Thanks for the explaining. Sounds like QScopedPointer(?)
  I have not used any of them now because it looked to me to have not much benefit in this case(?)
  
  BTW: I Always try to avoid a "Standard" version when there is a "Cute" available ;-) just only because std stuff looks for me ugly.
  
  The noted odd highlighting still happens when you do successive S(&R) tasks. Is it a feature? :-)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=47380&id=47408

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181212/d4f905ab/attachment.html>


More information about the Kde-frameworks-devel mailing list