D17459: SearchBar: Add Cancel button to stop long running tasks

loh tar noreply at phabricator.kde.org
Tue Dec 11 15:41:44 GMT 2018


loh.tar updated this revision to Diff 47362.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Code cosmetic
  - Add singleShot stuff
  
  That's my first draft of that requested singleShot approach, help is now appreciated.
  
  - Replace crashes due to (I think) these pointer instead of reference argument mismatch.
  - Find works odd. Most of the time looks good, searching "5" or "A" seams to run endless in our fat file
  - Can't see how that loop works, "line" is not incremented and I'm not sure if "done" is sufficient set

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=47275&id=47362

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181211/3f1f579b/attachment.html>


More information about the Kde-frameworks-devel mailing list