D17479: Fix build without phonon
Heiko Becker
noreply at phabricator.kde.org
Mon Dec 10 15:15:02 GMT 2018
heikobecker created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.
REVISION SUMMARY
f6d55baf5aa88eaab6b2f96c025064f081d13cea <https://phabricator.kde.org/R305:f6d55baf5aa88eaab6b2f96c025064f081d13cea> replaced ${PHONON_LIBS} with
Phonon's imported target. This breaks in the case when Phonon isn't
found or disabled via -DCMAKE_DISABLE_FIND_PACKAGES_Phonon4Qt5=TRUE
because the imported target isn't known. It worked previously because
was ${PHONON_LIBS} just empty when Phonon wasn't available.
TEST PLAN
Building without phonon works now and and it still builds
with phonon available and successfully links to it.
REPOSITORY
R305 KNotifyConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17479
AFFECTED FILES
src/CMakeLists.txt
To: heikobecker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181210/2eda3be2/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list