D17425: dcb settings

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> dcbsettingtest.cpp:28
> +#include <QTest>
> +#include <QList>
> +

Include not needed.

> dcbsetting.cpp:220
> +    } else {
> +        return false;
> +    }

You can remove the else branch and have just return false.

> dcbsetting.cpp:254
> +    } else {
> +        return 0;
> +    }

You can remove the else branch and have just return 0.

> dcbsetting.cpp:288
> +    } else {
> +        return 0;
> +    }

You can remove the else branch and have just return 0.

> dcbsetting.cpp:322
> +    } else {
> +        return 0;
> +    }

You can remove the else branch and have just return 0.

> dcbsetting.cpp:356
> +    } else {
> +        return false;
> +    }

You can remove the else branch and have just return false.

> dcbsetting.cpp:390
> +    } else {
> +        return 0;
> +    }

You can remove the else branch and have just return 0.

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181210/374cad56/attachment-0001.html>