D17425: dcb settings

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> dcbsettingtest.cpp:30
> +
> +typedef QList<quint32> UintList;
> +

Why? This type is defined in generictypes.h.

> dcbsetting.h:30
> +
> +typedef QList<quint32> UintList;
> +

Again, this is defined in generictypes.h.

> pranavgade wrote in dcbsetting.h:49
> I tried to do it in the same way as in ipv6 settings, so should i add Q_DECLARE_FLAGS() ?

Yes, add Q_DECLARE_FLAGS.

> dcbsetting_p.h:27
> +
> +typedef QList<quint32> UintList;
> +

Here as well.

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181210/d0ebbf7e/attachment-0001.html>