D17425: dcb settings

[Pranav Gade]

pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in dcbsetting.cpp:59
> This is odd, maybe we should introduce getters and setters for the whole list, this would simplify it and you can use it also in fromMap() and toMap()

Yeah, that would help.
Do you think I should do that?

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181210/1d45b342/attachment-0001.html>