D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

Nathaniel Graham noreply at phabricator.kde.org
Sun Dec 9 20:28:07 GMT 2018


ngraham created this revision.
ngraham added reviewers: VDG, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  When a `KDirOperator` view is used in Detailed or Detailed Tree view, when there isn't enough horizontal space the Name column currently gets squeezed and become illegible.
  
  This patch fixes that by making the name column fixed-width so it never gets too small to read the contents; instead the view gets a horizontal scrollbar, which is preferable.
  
  BUG: 401506
  FIXED-IN: 5.54

TEST PLAN
  In Kate's Filesystem Browser plugin sidebar view:
  
  In the open/save dialog when there's not enough horizontal space:
  
  In the open/save dialog when there //is// enough horizontal space:
  
  In this case, the other columns no longer stick to the right size of the view when the window is resized, which maybe isn't as nice as current behavior. Open to suggestions.

REPOSITORY
  R241 KIO

BRANCH
  kdiroperator-detail-view-name-column (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17461

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181209/7f30b306/attachment.html>


More information about the Kde-frameworks-devel mailing list