D9175: Migrate some more QRegExps to QRegularExpression

Dominik Haumann noreply at phabricator.kde.org
Sat Dec 8 17:24:45 GMT 2018


dhaumann added a comment.
Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks.


  Curent state: This patch is only almost good to go in... :-P

INLINE COMMENTS

> cullmann wrote in kateview.cpp:3595
> I think the old code tried to ensure we only add word-boundary if we still can find the string then. e.g. if the string that you highlight contains spaces or stuff like that at the borders, you don't add \b.

This part is still not done. Besides that, this patch should be fine.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9175

To: dhaumann, cullmann, kfunk, mwolff
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181208/a02ef5ae/attachment.html>


More information about the Kde-frameworks-devel mailing list