D16716: skip writing test if mime type is not supported by the extractor

[Stefan Brüns]

bruns added a comment.


  In D16716#357321 <https://phabricator.kde.org/D16716#357321>, @astippich wrote:
  
  > I think that's my fault when I introduced the extractor for test. Apparently it is using the system libraries, and I'm looking for a solution.
  >  I think a skip is still the right thing to do here, since we cannot determine if the tags are correctly written.
  
  
  I think skip should only be used iff the test does not apply (e.g. running a Windows specific test on Linux) or when some of the required fixtures can not be provided (e.g. running a test requiring network access in an isolated environment).
  
  In this case, it is "easy" to fulfill the requirements, just correct the test setup.
  
  Imagine what may have happened if this were a QSKIP from the beginning - it would have skipped the tests, and you might have committed untested code. I am not quite sure, but I think skips are not even reported when you run the complete test suite via `ctest`.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16716

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181205/a825d5c0/attachment.html>