D17342: team-port setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> teamportsettingtest.cpp:29
> +
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_TEAM_PORT_CONFIG        "config"

Those defines are already in NM 1.10

> teamportsettingtest.cpp:62
> +            << (qint32)1         // queueId
> +            << false             // sticky
> +            << linkWatchers;     // linkWatchers

set it to TRUE, otherwise it will fail once you fix the test

> teamportsettingtest.cpp:92
> +
> +    QVariantMap::const_iterator it = map.constBegin();
> +    NMVariantMapList list = it.value().value<NMVariantMapList>();

This is weird, this way only link-watchers should be compared, the rest should be identical to other unit tests.

> setting.cpp:34
>  
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_TEAM_PORT_SETTING_NAME  "team-port"

NM 1.10.0

> teamportsetting.cpp:26
> +
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_TEAM_PORT_SETTING_NAME "team-port"

NM 1.10.0

> teamportsetting.cpp:210
> +
> +    if (lacpKey() >= 0) {
> +        setting.insert(QLatin1String(NM_SETTING_TEAM_PORT_LACP_KEY), lacpKey());

> 0

> teamportsetting.cpp:214
> +
> +    if (lacpPrio() >= 0) {
> +        setting.insert(QLatin1String(NM_SETTING_TEAM_PORT_LACP_PRIO), lacpPrio());

!= 255

> teamportsetting.cpp:218
> +
> +    if (prio() >= 0) {
> +        setting.insert(QLatin1String(NM_SETTING_TEAM_PORT_PRIO), prio());

> 0

REVISION DETAIL
  https://phabricator.kde.org/D17342

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181205/c706fe8d/attachment-0001.html>