D17245: Add string formatting function to property info

[Alexander Stippich]

astippich marked 3 inline comments as done.
astippich added a comment.


  I'm wondering, anything else to do if I add a new dependency to KFileMetaData?

INLINE COMMENTS

> bruns wrote in propertyinfotest.cpp:63
> I think this should be "44.1 kHz". Insert the correct expected value and make it QEXPECT_FAIL?

That was a localization issue.

> bruns wrote in propertyinfotest.cpp:65
> dito, "128 kb/s"

I'm going to fix this shortly after, so I don't bother

> bruns wrote in formatstrings.cpp:80
> for 180°,  CCW is irrelevant.

That was pretty stupid :)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181204/7885addc/attachment-0001.html>